Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Bump sinatra, thin, and poltergeist #5

Closed
wants to merge 1 commit into from

Conversation

girasquid
Copy link

Sinatra and Thin so that they can handle Rack 2.0, which Rails 5 requires. Poltergeist so that brew-installed phantomjs works.

@j-mutter @bslobodin

Sinatra and Thin so that they can handle Rack 2.0, which Rails 5 requires. Poltergeist so that brew-installed phantomjs works.
@girasquid
Copy link
Author

The test suite...doesn't actually run for me using the updated poltergeist/phantomjs OR the old one; when you install using their README instructions the qless-core that you're testing against has problems like this all the way down:

  126) Qless::ClientEvents can pick up on pop events
     Failure/Error: client.jobs[queue.put(Qless::Job, { foo: 'bar' })]
     Redis::CommandError:
       ERR Error running script (call to f_3f9682e7ddb462dca8c60a26d5e88ac70c3a49e9): @user_script:925: @user_script: 925: Lua redis() command arguments must be strings or integers

@girasquid
Copy link
Author

Known issue!. Poking at downgrading my redis and experimenting.

Copy link

@bslobodin bslobodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, umm, it took us a while to find courage to review/approve New Relic, how are we going to actually review all these gem changes?

metriks (~> 0.9)
redis (>= 2.2, < 4.0.0.rc1)
rusage (~> 0.2.0)
sentry-raven (~> 0.4)
sinatra (~> 1.3)
sinatra (= 2.0.0beta2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta 😢

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girasquid
Copy link
Author

This PR just bumps sinatra + thin instead of dealing with poltergeist at all: #6

@girasquid girasquid closed this Jan 16, 2017
@girasquid girasquid deleted the bump-sinatra-and-thin branch January 16, 2017 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants