Filter versions while testing #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
force-pushed
the
ko/filter-version-in-test
branch
from
cf6565b to
04ae129
Compare
KaanOzkan
force-pushed
the
ko/filter-version-in-test
branch
3 times, most recently
from
538b616 to
0ad1695
Compare
egiurleo
approved these changes
Sep 30, 2024
KaanOzkan
force-pushed
the
ko/filter-version-in-test
branch
from
f9e8b05 to
f12cd6c
Compare
KaanOzkan
force-pushed
the
ko/filter-version-in-test
branch
from
f12cd6c to
f0e3028
Compare
Morriar
approved these changes
Sep 30, 2024
|
|
||
| private | ||
|
|
||
| sig { params(gem_name: String, annotations_file: String).returns(String) } |
There was a problem hiding this comment.
I wonder if this should go in the parent class?
There was a problem hiding this comment.
Runtime doesn't need it at the moment but yeah it's not specific to static. I'll move it.
|
|
||
| sig { params(gem_name: String, annotations_file: String).returns(String) } | ||
| def filter_versions_from_annotation(gem_name, annotations_file) | ||
| gem_version = ::Gem::Version.new(gem_version_from_gemfile_lock(gem_name)) |
There was a problem hiding this comment.
Maybe the upstream gem_version_from_gemfile_lock should return a Version instance rather than a string?
There was a problem hiding this comment.
Yeah that aligns better with the name. I can add a to_s to the usages in Spoom that expects a string. I'll unblock rbi-central with the current change and bump spoom in another PR after it's implemented.
KaanOzkan
force-pushed
the
ko/filter-version-in-test
branch
from
f0e3028 to
b5f3391
Compare
This was referenced Sep 30, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary support for testing annotations with versions.
In a future improvement we should test all versions and not just one used in CI which should be the latest version: #287