Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation for ActiveRecord::Relation#each #290

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add annotation for ActiveRecord::Relation#each #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rbi/annotations/activerecord.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,12 @@ class ActiveRecord::Base
end

class ActiveRecord::Relation
Elem = type_member(:out) { { fixed: T.untyped } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, it's odd that Sorbet is requiring this, as ActiveRecord::Relation already does an include Enumerable:

https://github.com/rails/rails/blob/f481602bc5f0e2b79f95b73d7cc343303dd69672/activerecord/lib/active_record/relation.rb#L67

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, Sorbet always makes you re-declare generic type variables.


sig { returns(T::Boolean) }
def blank?; end

sig { abstract.params(blk: T.proc.params(arg0: Elem).returns(BasicObject)).returns(T.untyped) }
sig { abstract.returns(T::Enumerator[Elem]) }
def each(&blk); end
end
Loading