Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the way of importing the VERSION constant #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve the way of importing the VERSION constant #719

wants to merge 1 commit into from
+2 −1

Conversation

xsamueljr
Copy link

When having a file with one single line declaring a constant (the shopify.version module), loading it by using exec() is a pretty weird method. You should just import the constant instead. This improves code readability and follows best practices for importing modules

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@matteodepalo
Copy link
Contributor

Thank you @xsamueljr ! Could you please sign the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed Waiting for Response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsamueljr @matteodepalo