Fix bugs in translation of PM_RESCUE_NODE
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
force-pushed
the
emily/rescue
branch
from
60a579b
to
648e0f1
Compare
egiurleo
changed the title
PM_RESCUE_NODEPM_RESCUE_NODE
st0012
approved these changes
Nov 1, 2024
amomchilov
reviewed
Nov 1, 2024
egiurleo
force-pushed
the
emily/rescue
branch
2 times, most recently
from
2cdea4e
to
c24cdd7
Compare
egiurleo
commented
Nov 4, 2024
amomchilov
approved these changes
Nov 5, 2024
| @@ -1639,7 +1641,7 @@ unique_ptr<parser::Node> Translator::translateStatements(pm_statements_node *stm | |||
| // Usually returns the `SorbetLHSNode`, but for constant writes and targets, | |||
| // it can can return an `LVarLhs` as a workaround in the case of a dynamic constant assignment. | |||
| template <typename PrismLhsNode, typename SorbetLHSNode> | |||
| unique_ptr<parser::Node> Translator::translateConst(PrismLhsNode *node) { | |||
| unique_ptr<parser::Node> Translator::translateConst(PrismLhsNode *node, bool skipDynamicConstantWorkaround) { | |||
There was a problem hiding this comment.
Could you add a blurb to the function docs that explains what this is (and why constant path op assignments need it)?
There was a problem hiding this comment.
@amomchilov Let me know what you think of the explanation above!
egiurleo
force-pushed
the
emily/rescue
branch
2 times, most recently
from
7f71bc9
to
576c29c
Compare
Only do the dynamic constant assignment workaround when translating a constant from a `PM_CONSTANT_WRITE_NODE` and `PM_CONSTANT_PATH_NODE`.
egiurleo
force-pushed
the
emily/rescue
branch
from
576c29c
to
fcc8a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #316
Motivation
Easiest to read each commit separately.
This PR addresses some issues with
PM_RESCUE_NODE:translateConst, rather than just the ones that actually handle constant assignment.Test plan
See included automated tests.