Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of Prism location test errors #321

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

egiurleo
Copy link

@egiurleo egiurleo commented Nov 25, 2024

Motivation

When I implemented the Prism location test runner, I accidentally switched the diff output so the expected parse tree showed up as the test output and vice versa.

For example, if I purposely make the alias location tests error by removing the symbol name, this is what the output looks like:

       "type" : "Alias",
       "from" : {
         "type" : "Symbol",
-        "val" : ""
+        "val" : "new_method1"
       },

This PR just fixes the test output, making it correct and easier for us to read.

Test plan

See included automated tests.

@egiurleo egiurleo self-assigned this Nov 25, 2024
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@egiurleo egiurleo merged commit e2bbd7c into prism Nov 25, 2024
1 check passed
@egiurleo egiurleo deleted the emily/fix-location-test branch November 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants