Do not mark classes that inherit from ActiveJob::TestCase as dead

Shopify · Jul 29, 2024 · 3e8ae20 · 3e8ae20
1 parent 6087731
commit 3e8ae20
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/spoom/deadcode/plugins/active_job.rb b/lib/spoom/deadcode/plugins/active_job.rb
@@ -5,6 +5,7 @@ module Spoom
   module Deadcode
     module Plugins
       class ActiveJob < Base
+        ignore_classes_inheriting_from("ActiveJob::TestCase")
         ignore_classes_named("ApplicationJob")
         ignore_methods_named("perform", "build_enumerator", "each_iteration")
       end

diff --git a/test/spoom/deadcode/plugins/active_job_test.rb b/test/spoom/deadcode/plugins/active_job_test.rb
@@ -49,6 +49,15 @@ def perform; end
           )
         end
 
+        def test_ignores_activejob_testcase_class_definition
+          @project.write!("test/foo_test.rb", <<~RB)
+            class FooTest < ActiveJob::TestCase
+            end
+          RB
+
+          assert_ignored(index_with_plugins, "FooTest")
+        end
+
         private
 
         sig { returns(Deadcode::Index) }