Add new visitor for Prism::ConstantPathNode

Shopify · May 13, 2024 · 9a27f3d · 9a27f3d
1 parent b16c222
commit 9a27f3d
Show file tree

Hide file tree

Showing 3 changed files with 4,861 additions and 3,939 deletions.
diff --git a/lib/spoom/deadcode/indexer.rb b/lib/spoom/deadcode/indexer.rb
@@ -174,6 +174,12 @@ def visit_constant_read_node(node)
         reference_constant(node.name.to_s, node)
       end
 
+      sig { override.params(node: Prism::ConstantPathNode).void }
+      def visit_constant_path_node(node)
+        visit(node.parent) if node.parent
+        reference_constant(node.name.to_s, node)
+      end
+
       sig { override.params(node: Prism::ConstantWriteNode).void }
       def visit_constant_write_node(node)
         name = node.name.to_s

diff --git a/lib/spoom/deadcode/visitor.rb b/lib/spoom/deadcode/visitor.rb
@@ -191,11 +191,6 @@ def visit_constant_path_and_write_node(node)
         visit_child_nodes(node)
       end
 
-      sig { override.params(node: Prism::ConstantPathNode).void }
-      def visit_constant_path_node(node)
-        visit_child_nodes(node)
-      end
-
       sig { override.params(node: Prism::ConstantPathOperatorWriteNode).void }
       def visit_constant_path_operator_write_node(node)
         visit_child_nodes(node)