Improve deadcode plugin for Minitest #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we relied on the name ending with `Test` which is not as precise. Signed-off-by: Alexandre Terrasa <[email protected]>
amomchilov
approved these changes
Jul 10, 2024
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Morriar
force-pushed
the
at-deadcode-minitest
branch
from
8b9c675 to
b0f50e1
Compare
This was referenced Jul 29, 2024
Morriar
added a commit
that referenced
this pull request
Jul 30, 2024
Since we only index `.rb` files, the relationship between `ActiveJob::TestCase` and `ActiveSupport::TestCase` and other intermediate classes that may only exist in the RBI files isn't seen by Spoom... Signed-off-by: Alexandre Terrasa <[email protected]>
Morriar
added a commit
that referenced
this pull request
Jul 30, 2024
Revert Improve deadcode plugin for Minitest #579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest::Testinstead of those ending withTeston_define_methodmethod to ignore methods starting withtest_or included in theMINITEST_METHODSset only when inside aMinitest::Testsubclass.on_sendto mark methods used inassert_predicateandrefute_predicateas alive.