Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all errors raised by spoom subclass Spoom::Error #580

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Make all errors raised by spoom subclass Spoom::Error #580

merged 1 commit into from
Jul 8, 2024
+2 −2

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 5, 2024

This makes it easier to rescue Spoom:Error from clients

@Morriar Morriar added the chore Chore task label Jul 5, 2024
@Morriar Morriar self-assigned this Jul 5, 2024
@Morriar Morriar requested a review from a team as a code owner July 5, 2024 16:43
@Morriar Morriar requested review from amomchilov and egiurleo July 5, 2024 16:43
egiurleo
egiurleo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Love this error clean up

@Morriar Morriar merged commit 8584417 into main Jul 8, 2024
8 checks passed
@Morriar Morriar deleted the at-errors branch July 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@amomchilov amomchilov Awaiting requested review from amomchilov amomchilov is a code owner automatically assigned from Shopify/sorbet

Assignees

@Morriar Morriar

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @egiurleo