Allow nilable Spoom::Location lines and columns attributes

[alexcrocha]

Summary

This PR updates the Spoom::Location class to allow the start_line, end_line, start_column, and end_column attributes to be nilable. This change provides greater flexibility in representing different types of locations within a file.

Details

• Nilable Attributes: The start_line, end_line, start_column, and end_column attributes of Spoom::Location can now be nil.
• Flexible Spoom::Location Representation:
  • Can now represent an entire file, e.g., foo.rb.
  • It can also represent a range of lines within a file, e.g., foo.rb:1-3.
  • Maintains previous implementation, with both lines and columns, e.g., foo.rb:1:2-3:4.

What should Reviewers pay attention to

• Exception Messages: Added more detailed messages to exceptions raised within the Spoom::Location class to improve debugging and error handling. Unsure if this is a good change.
• Float::Infinity: Introduced Float::Infinity to represent inclusivity when lines or columns are nil, ensuring that ranges can be handled correctly even when the start or end is not explicitly known.

[andyw8]

Are there perhaps two distinct concepts here that should be seperated out, e.g. LocationPosition and a LocationRange ?

[egiurleo]

Seconding Andy's question, and I was also wondering what the use case is here -- what are you planning to implement that uses this feature? NVM saw your other issue! Makes sense.

[Morriar]

I'd prefer an early raise and an unconditional return:

Suggested change

	start_line, end_line = T.must(start_line).split("-", 2)
	return new(file, start_line: start_line.to_i, end_line: end_line.to_i) if end_line
	raise LocationError, "Invalid location. End line is missing in range format: #{location_string}"
	start_line, end_line = T.must(start_line).split("-", 2)
	raise LocationError, "Invalid location. End line is missing in range format: #{location_string}" unless end_line
	return new(file, start_line: start_line.to_i, end_line: end_line.to_i) if end_line

So the style and logic is coherent with the other branches.

[Morriar]

Indeed, maybe the Location concept is not a good representation, maybe what we want is the concept of File vs. FileLocation. Though I'm wary of doing the refactoring right now as we are still exploring how we want to modelize whole file removals.

For now, the nilability change suits our needs and doesn't commit us to one direction or another 👍

[Morriar]

One small nit, we can merge once fixed 🎉

[Morriar]

Does this fit in one line?

Suggested change

	if rest.nil?
	raise LocationError, "Invalid location string `#{location_string}`: missing end line and column"
	raise LocationError, "Invalid location string `#{location_string}`: missing end line and column" if rest.nil?

[alexcrocha]

It does, good catch! 🕵️