Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sorbet-static-and-runtime from 0.5.11553 to 0.5.11577 in the minor-and-patch group across 1 directory #607

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Bump sorbet-static-and-runtime from 0.5.11553 to 0.5.11577 in the minor-and-patch group across 1 directory #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ca0e20
Bump sorbet-static-and-runtime
dependabot[bot] Sep 23, 2024
87f62e0
Update help output expectation
KaanOzkan Sep 25, 2024
cb45826
Update sorbet metric prefix
KaanOzkan Sep 25, 2024
fd3f77c
Fix test warnings
KaanOzkan Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ GEM
rdoc (6.6.3.1)
psych (>= 4.0.0)
regexp_parser (2.9.2)
reline (0.5.0)
reline (0.5.10)
io-console (~> 0.5)
rexml (3.3.6)
strscan
Expand All @@ -68,14 +68,14 @@ GEM
rubocop-sorbet (0.8.5)
rubocop (>= 1)
ruby-progressbar (1.13.0)
sorbet (0.5.11553)
sorbet-static (= 0.5.11553)
sorbet-runtime (0.5.11553)
sorbet-static (0.5.11553-universal-darwin)
sorbet-static (0.5.11553-x86_64-linux)
sorbet-static-and-runtime (0.5.11553)
sorbet (= 0.5.11553)
sorbet-runtime (= 0.5.11553)
sorbet (0.5.11577)
sorbet-static (= 0.5.11577)
sorbet-runtime (0.5.11577)
sorbet-static (0.5.11577-universal-darwin)
sorbet-static (0.5.11577-x86_64-linux)
sorbet-static-and-runtime (0.5.11577)
sorbet (= 0.5.11577)
sorbet-runtime (= 0.5.11577)
stringio (3.1.0)
strscan (3.1.0)
tapioca (0.16.2)
Expand Down
2 changes: 1 addition & 1 deletion lib/spoom/sorbet/metrics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
module Spoom
module Sorbet
module MetricsParser
DEFAULT_PREFIX = "ruby_typer.unknown.."
DEFAULT_PREFIX = "ruby_typer.unknown."

class << self
extend T::Sig
Expand Down
13 changes: 3 additions & 10 deletions test/spoom/context/sorbet_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,10 @@ def test_context_run_srb_from_path
capture_err: true,
sorbet_bin: Spoom::Sorbet::BIN_PATH,
)
assert_equal(<<~OUT, result.err)
Typechecker for Ruby
assert_includes(result.err, <<~OUT)
Sorbet: A fast, powerful typechecker designed for Ruby
Usage:
sorbet [OPTION...] <path 1> <path 2> ...

-e string Parse an inline ruby string (default: "")
-q, --quiet Silence all non-critical errors
-v, --verbose Verbosity level [0-3]
-h Show short help
--help Show long help
--version Show version
sorbet [options] [[--] <path>...]

OUT
assert(result.status)
Expand Down
4 changes: 2 additions & 2 deletions test/spoom/sorbet/metrics_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ def test_parses_metrics
"uuid": "some-uuid",
"metrics": [
{
"name": "ruby_typer.unknown..error.total",
"name": "ruby_typer.unknown.error.total",
"value": 1
},
{
"name": "ruby_typer.unknown..types.input.sends.total",
"name": "ruby_typer.unknown.types.input.sends.total",
"value": 2094
}
]
Expand Down
1 change: 1 addition & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def spoom_gemfile
gemspec name: "spoom", path: "#{SPOOM_PATH}"
gem "tapioca"
gem "sorbet-static-and-runtime", "#{Sorbet::GEM_VERSION}"
gem "json", "2.7.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 75 failures due to /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. so I opted for a general solution for all tests.

GEMFILE
end

Expand Down
Loading