Skip to content

Commit

Permalink
Merge pull request #279 from Shopify/dominiquelflaaa.br_neighborhood_…
Browse files Browse the repository at this point in the history
…required

neighborhood required in BR, cut v1.9.0
  • Loading branch information
DominiqueFlaaa authored Aug 21, 2024
2 parents 50a277c + 5198a51 commit 3736a10
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 4 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Security in case of vulnerabilities.

## [Unreleased]
- add support for additional address fields streetName, streetNumber in DE [#273](https://github.com/Shopify/worldwide/pull/273)
- Nil.

---

## [1.9.0] - 2024-08-12
- add support for additional address fields streetName, streetNumber in DE [#273](https://github.com/Shopify/worldwide/pull/273)
- set additional_field neighborhood as required in BR [#279](https://github.com/Shopify/worldwide/pull/279)


## [1.8.0] - 2024-08-09
- Bump Ruby to 3.3.1; drop support for 3.0.x [#264](https://github.com/Shopify/worldwide/pull/264)
- Add support for partial zip matching for SG [#271](https://github.com/Shopify/worldwide/pull/271)
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ GIT
PATH
remote: .
specs:
worldwide (1.8.0)
worldwide (1.9.0)
activesupport (>= 7.0)
i18n
phonelib (~> 0.8)
Expand Down
1 change: 1 addition & 0 deletions db/data/regions/BR.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ additional_address_fields:
required: true
- name: line2
- name: neighborhood
required: true
combined_address_format:
default:
address1:
Expand Down
2 changes: 1 addition & 1 deletion lib/worldwide/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Worldwide
VERSION = "1.8.0"
VERSION = "1.9.0"
end
2 changes: 1 addition & 1 deletion test/worldwide/region_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ class RegionTest < ActiveSupport::TestCase
test "additional_address_fields returns values as expected" do
[
[:us, []],
[:br, [{ "name" => "streetName", "required" => true }, { "name" => "streetNumber", "required" => true }, { "name" => "line2" }, { "name" => "neighborhood" }]],
[:br, [{ "name" => "streetName", "required" => true }, { "name" => "streetNumber", "required" => true }, { "name" => "line2" }, { "name" => "neighborhood", "required" => true }]],
[:be, [{ "name" => "streetName", "required" => true }, { "name" => "streetNumber", "required" => true }]],
[:id, [{ "name" => "line2" }, { "name" => "neighborhood" }]],
[:tr, [{ "name" => "line2" }, { "name" => "neighborhood", "required" => true }]],
Expand Down

0 comments on commit 3736a10

Please sign in to comment.