Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved navbar in mobile view #251

Merged
merged 5 commits into from
Feb 18, 2024

Conversation

KeyurGK
Copy link
Contributor

@KeyurGK KeyurGK commented Feb 7, 2024

Fixes #200

Changes proposed

Before :

  • The navbar transitioned from the top as a drop-down, covering the product list giving the user a bad UX.

image

After :

  • The new navbar in mobile screens, transitions from the right side.
  • The navbar remains fixed, as the user scrolls through the product list.
NAVBAR_DEMO.mp4

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for ar-webstore ready!

Name Link
🔨 Latest commit a7b1335
🔍 Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65d21bd26b187e00089cb56e
😎 Deploy Preview https://deploy-preview-251--ar-webstore.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShwetKhatri2001
Copy link
Owner

Can you please make these two small changes. It can be merged after that.

  • Close the sidebar when any link present inside is clicked.
  • Reduce the font size of link labels ( text ) probably to the previous size.

@KeyurGK
Copy link
Contributor Author

KeyurGK commented Feb 11, 2024

Can you please make these two small changes. It can be merged after that.

  • Close the sidebar when any link present inside is clicked.
  • Reduce the font size of link labels ( text ) probably to the previous size.

Updated with recommended changes @ShwetKhatri2001 :

NAVBAR.mp4

Copy link
Owner

@ShwetKhatri2001 ShwetKhatri2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 Congrats @KeyurGK on your first PR getting merged on AR-Webstore 🚀 Keep Contributing 👍

@ShwetKhatri2001 ShwetKhatri2001 merged commit b9e0004 into ShwetKhatri2001:master Feb 18, 2024
6 checks passed
@ShwetKhatri2001 ShwetKhatri2001 added enhancement Enhacing existing feature Easy easy level issue SWOC S4 Assigned to SWOC S4 contributor labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy easy level issue enhancement Enhacing existing feature SWOC S4 Assigned to SWOC S4 contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]:Add Better Navbar in mobile View
2 participants