Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WishList implemented successfully! #257

Closed
wants to merge 4 commits into from
Closed

WishList implemented successfully! #257

wants to merge 4 commits into from

Conversation

ayann07
Copy link
Contributor

@ayann07 ayann07 commented Feb 25, 2024

Fixes Issue

Issue No. : #195 is now fixed.

Changes proposed

WishList section is implemented now so that user can click on the + button and item will be added to wishlist and if user want to remove the item he can again click on button to remove it. User can also remove wishlist items by going in wishlist section.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Demo Video:-

wishlist-demo.mp4

I have worked this under SWOC 2024

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for ar-webstore ready!

Name Link
🔨 Latest commit bd39206
🔍 Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65dcc7787b000500088e9587
😎 Deploy Preview https://deploy-preview-257--ar-webstore.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShwetKhatri2001
Copy link
Owner

I looked at your changes, and it was good. But you need to fix the failing deploy preview. Go through 🔍 Latest deploy log link given above.

@ayann07
Copy link
Contributor Author

ayann07 commented Feb 26, 2024

Now you may check deploy preview, it is working fine now.

@ayann07
Copy link
Contributor Author

ayann07 commented Feb 27, 2024

@ShwetKhatri2001 please see to it.

@ShwetKhatri2001
Copy link
Owner

It's breaking many of the existing features and having issues like in the home page all items are in a single column, the feedback page is small in width, sign-in and sign-up pages show 404.

The wishlist is working but I can't merge that while breaking others. Please take a look and fix those.
You haven't merged all the latest changes yet I think.

@ayann07
Copy link
Contributor Author

ayann07 commented Feb 27, 2024

Let me fork again so I will get all data latest and then make changes then

@ayann07
Copy link
Contributor Author

ayann07 commented Feb 27, 2024

Give me 2 hours, I will create a fresh pr

@ayann07 ayann07 closed this by deleting the head repository Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants