Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display paired token rewards per pool for an LP address #860

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

pgoos
Copy link
Collaborator

@pgoos pgoos commented Dec 20, 2023

Screenshot 2023-12-20 at 22 09 49

@pgoos pgoos requested review from monilpat, sx0785 and snobbee December 20, 2023 21:10
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sifchain-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:14pm

Comment on lines +183 to +187
const ibcDenom =
tokenRegistryEntriesQuery.data.value?.registry?.entries.find(
(y) => y.baseDenom === pool.externalAmount.symbol,
)?.denom;
const denomOrSymbol = ibcDenom ?? pool.externalAmount.symbol;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind explaining this? thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to introduce this code to get ibc hash of external token. For some reason it wasn't available as part of pool.externalAmount.ibcDenom

Copy link

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pgoos pgoos merged commit fc36970 into master Dec 20, 2023
5 of 6 checks passed
@pgoos pgoos deleted the feat/display-paired-token-rewards branch December 20, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants