Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: author shows as undefined in the app store #1872

Closed
wants to merge 3 commits into from

Conversation

sbender9
Copy link
Member

No description provided.

@sbender9 sbender9 added the fix label Jan 29, 2025
@sbender9 sbender9 requested a review from tkurkii January 29, 2025 21:01
@sbender9 sbender9 changed the title fix: author show as undefined in the app store fix: author shows as undefined in the app store Jan 29, 2025
@tkurki
Copy link
Member

tkurki commented Feb 1, 2025

In #1868 I was thinking that let's not make people's emails so prominent. I think they are required by npm (when you register) but not visible in npm ui, so i'd prefer not showing it.

What do you think? Email kinda prompts people to request support by email.

@tkurki
Copy link
Member

tkurki commented Feb 2, 2025

Merged #1868 instead.

@tkurki tkurki closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants