error: `allow` attribute without specifying a reason --> lib/stablevec/src/lib.rs:2:1 | 2 | / #![allow( 3 | | unsafe_code, 4 | | // reason = "this entire crate relies heavily on scary memory tricks" 5 | | )] | |__^ | = help: try adding a reason at the end with `, reason = ".."` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#allow_attributes_without_reason = note: requested on the command line with `-D clippy::allow-attributes-without-reason`

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: missing documentation for a method --> lib/stablevec/src/debug.rs:4:5 | 4 | pub const fn bytes_allocated(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:338:5 | 338 | pub fn as_slice_mut(&mut self) -> Option<&mut [T]> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:330:5 | 330 | pub fn as_slice(&self) -> Option<&[T]> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:279:5 | 279 | pub fn swap(&mut self, a: usize, b: usize) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:258:5 | 258 | pub fn is_fragmented(&self) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:254:5 | 254 | pub fn is_init(&self, index: usize) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:250:5 | 250 | pub fn enumerate(&self) -> impl Iterator<Item = (usize, &T)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:242:5 | 242 | pub fn iter(&self) -> impl Iterator<Item = &T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:238:5 | 238 | pub fn as_uninit_slice_mut(&mut self) -> &mut [MaybeUninit<T>] { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:234:5 | 234 | pub fn as_uninit_slice(&self) -> &[MaybeUninit<T>] { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:217:5 | 217 | pub fn extend_from_other(&mut self, mut other: Self) -> HashMap<usize, usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:213:5 | 213 | pub fn extend_from_iter(&mut self, iter: impl IntoIterator<Item = T>) -> Vec<usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:205:5 | 205 | / pub fn push_iter<'s>( 206 | | &'s mut self, 207 | | iter: impl IntoIterator<Item = T> + 's, 208 | | ) -> impl Iterator<Item = usize> + 's { | |_________________________________________^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:179:5 | 179 | pub fn push(&mut self, data: T) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:171:5 | 171 | pub fn get_mut(&mut self, index: usize) -> Option<&mut T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:163:5 | 163 | pub fn get(&self, index: usize) -> Option<&T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:127:5 | 127 | pub fn remove(&mut self, index: usize) -> Option<T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a method --> lib/stablevec/src/lib.rs:80:5 | 80 | pub fn init_flags(&self) -> &BitVec { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: requested on the command line with `-W missing-docs`

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:372:9 | 372 | unsafe { self.get_unchecked_mut(index) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:366:9 | 366 | unsafe { self.get_unchecked(index) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: consider adding a `;` to the last statement for consistent formatting --> lib/stablevec/src/lib.rs:349:9 | 349 | self.clear() | ^^^^^^^^^^^^ help: add a `;` here: `self.clear();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:342:18 | 342 | Some(unsafe { mem::transmute::<&mut [MaybeUninit<T>], &mut [T]>(&mut *self.data) }) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:305:17 | 305 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:301:21 | 301 | let mut i = unsafe { self.flags.last_one().unwrap_unchecked() }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:283:9 | 283 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:271:9 | 271 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:228:17 | 228 | unsafe { other.flags.set_unchecked(i, false) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:227:41 | 227 | res.insert(i, self.push(unsafe { odata.add(i).read() })); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:197:17 | 197 | unsafe { ptr::drop_in_place::<T>(&mut *p.add(i).cast::<T>()) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:187:9 | 187 | unsafe { self.set_unchecked(index, data) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> lib/stablevec/src/lib.rs:180:21 | 180 | let index = match self.flags.first_zero() { | _____________________^ 181 | | Some(i) => i, 182 | | None => { 183 | | self.grow_amortized(1); 184 | | self.capacity() - 1 185 | | } 186 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else = note: requested on the command line with `-W clippy::single-match-else` help: try | 180 ~ let index = if let Some(i) = self.flags.first_zero() { i } else { 181 + self.grow_amortized(1); 182 + self.capacity() - 1 183 ~ }; |

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:175:32 | 175 | Some(true) => Some(unsafe { self.get_unchecked_mut(index) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:166:32 | 166 | Some(true) => Some(unsafe { self.get_unchecked(index) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:159:9 | 159 | unsafe { self.data[index].assume_init_mut() } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:145:9 | 145 | unsafe { self.data[index].assume_init_ref() } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:131:9 | 131 | unsafe { self.remove_unchecked(index) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:121:18 | 121 | Some(unsafe { self.data.as_ptr().add(index).cast::<T>().read() }) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/lib.rs:119:12 | 119 | if unsafe { self.flags.replace_unchecked(index, false) } { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: backticks are unbalanced --> lib/stablevec/src/macros.rs:1:5 | 1 | /// Create a [StableVec] containing the arguments, as with [std::vec!]`. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: a backtick may be missing a pair = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown

warning: `todo` should not be present in production code --> lib/stablevec/src/debug.rs:5:9 | 5 | todo!() | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`

warning: unsafe block missing a safety comment --> lib/stablevec/src/conv.rs:47:19 | 47 | data: unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/conv.rs:19:19 | 19 | data: unsafe { mem::transmute::<Box<[T]>, Box<[MaybeUninit<T>]>>(b) }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:325:21 | 325 | self.data = unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:315:19 | 315 | let ptr = unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:296:9 | 296 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: consider adding a `;` to the last statement for consistent formatting --> lib/stablevec/src/alloc.rs:297:13 | 297 | / self.grow(match self.capacity().checked_add(additional) { 298 | | Some(c) => c.max(self.len_init() * 2).max(Self::MIN_NON_ZERO_CAP), 299 | | None => capacity_overflow(), 300 | | }) | |______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned help: add a `;` here | 297 ~ self.grow(match self.capacity().checked_add(additional) { 298 + Some(c) => c.max(self.len_init() * 2).max(Self::MIN_NON_ZERO_CAP), 299 + None => capacity_overflow(), 300 + }); |

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:288:9 | 288 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:276:13 | 276 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:248:13 | 248 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:239:9 | 239 | unsafe { self.shrink(new_cap) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:148:13 | 148 | unsafe { res.data[i].write(self.data[i].assume_init_ref().clone()) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:115:5 | 115 | unsafe { NonNull::new_unchecked(res) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:110:9 | 110 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:103:15 | 103 | let res = unsafe { std::alloc::alloc(new_layout) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: this argument is passed by value, but not consumed in the function body --> lib/stablevec/src/alloc.rs:92:17 | 92 | new_layout: Result<Layout, LayoutError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Result<Layout, LayoutError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value note: the lint level is defined here --> lib/stablevec/src/alloc.rs:90:8 | 90 | #[warn(clippy::needless_pass_by_value)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:53:5 | 53 | unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:48:15 | 48 | let ptr = unsafe { std::alloc::alloc(layout) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks

warning: unsafe block missing a safety comment --> lib/stablevec/src/alloc.rs:33:16 | 33 | return unsafe { | ^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks = note: requested on the command line with `-W clippy::undocumented-unsafe-blocks`

warning: item in documentation is missing backticks --> lib/stablevec/src/../README.md:1:3 | 1 | # StableVec | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: requested on the command line with `-W clippy::doc-markdown` help: try | 1 | # `StableVec` | ~~~~~~~~~~~

warning: unexpected `cfg` condition value: `nightly` --> lib/stablevec/src/conv.rs:38:23 | 38 | #[cfg(not(feature = "nightly"))] | ^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default` = help: consider adding `nightly` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration