Fix 917 SoC build if button component disabled #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Dec 4, 2024
selissia
approved these changes
Dec 4, 2024
bhmanda-silabs
force-pushed
the
fix/917_soc_build_if_button_component_disabled
branch
from
6cc76e0 to
451bb57
Compare
bhmanda-silabs
requested review from
jepenven-silabs,
mkardous-silabs,
lpbeliveau-silabs and
rcasallas-silabs
as code owners
mkardous-silabs
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Matter-Wifi projects compilation errors are coming if button component is disabled.
Change overview
Added SL_CATALOG_SIMPLE_BUTTON_PRESENT for button code
Testing
Tested the build locally with wifi boards