-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZGW-3430: Add Z-Wave API serial logs #30
base: main
Are you sure you want to change the base?
ZGW-3430: Add Z-Wave API serial logs #30
Conversation
7163435
to
c85882d
Compare
9899f2d
to
ea45531
Compare
Add a decoder to parse the SAPI logs generated by the Z/IP Gateway. The original script works on ZPC. This commit adapts the script to parse traces generated by the Z/IP Gateway. Original script available at https://github.com/SiliconLabs/UnifySDK/blob/ver_1.6.0/scripts/serial_decode_zpc.py
ea45531
to
a3d4a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May this be reverted
The Z/IP Gateway is reusing the script to parse SAPI logs. The script was adjusted to be compatible with the ZGW logs. Adding a reference to the ZGW copy on the original script. Related-to: SiliconLabs/zipgateway#30
What do you want to revert? |
If we want to slim it down to minimum, and do the maintenance at unify, to avoid divergence. |
I think this would be nice to have in z-w-p-c too |
Update: This script will be probably maintained at: Until it is isolated in separate project should we duplicate the file ? one solution would be to replace a script "download-serial_decode_zpc.py" that will download the latest released version: eg: BTW, I would suggest user to update the script to fetch latest release if available Any thought ? or is it over-engineered ? |
Add a decoder to parse the SAPI logs generated by the Z/IP Gateway.
The original script works on ZPC. This commit adapts the script to parse traces generated by the Z/IP Gateway.
Original script available at https://github.com/SiliconLabs/UnifySDK/blob/main/scripts/serial_decode_zpc.py