Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in settings to prevent premature uninstalls #312

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

jaretpr
Copy link

@jaretpr jaretpr commented Aug 12, 2024

  • Created a section within the settings to indicate to users that spawn times may not be immediate.

@SimonStnn SimonStnn self-requested a review August 16, 2024 07:50
@SimonStnn SimonStnn changed the base branch from main to dev August 16, 2024 07:56
@SimonStnn SimonStnn self-assigned this Aug 16, 2024
@SimonStnn
Copy link
Owner

SimonStnn commented Aug 18, 2024

Hello @jaretpr, thank you for your contribution.

It seems a bit out of place to place a note at the bottom of the settings page. Especially since you've placed it in the developer form component, this is not related to that component.
Have you actually tried running what you've made? Because the text isn't readable and the styling is different then the rest of the page. I was hoping you might notice these issues as well.

I'm also not sure if the bottom of the settings page is the best place to mention this.

Copy link
Owner

@SimonStnn SimonStnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't leave these changes in this file.

Comment on lines +75 to +77
<div data-orientation="horizontal" role="none" className="bg-border h-[1px] w-full">
<span className="select-none invisible">‎</span>
</div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the installed separator component for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants