[3.0] Fix blank screens in error log #8319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed by Shawn Bulen, [email protected]
Signed by Shawn Bulen, [email protected]
Signed by Shawn Bulen, [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #8307
Prior to php 8.3, highlight_string() added some wrapper code before & after the requested code - code tags, spans, etc. Including line feeds... Since eols were returned as br tags within the requested code, you could easily strip the wrapper line feeds by mapping \n to ''.
With 8.3, everything comes back using newlines, both the requested code & the wrapper code, so stripping newlines broke stuff by turning the whole program into one large line...
Two tweaks needed:
Tested in php 8.l, 8.2, and 8.3.