Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose support #1

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Docker compose support #1

merged 3 commits into from
Jan 26, 2024

Conversation

GerardSmit
Copy link
Contributor

Added Docker compose support:

docker compose build
docker compose up

Backend

  1. Fixed exception after applying migrations (Database.Migrate() opens the connection, so it was already open)
  2. Fixed incorrect path in Dockerfile

Frontend

  1. Added Dockerfile
  2. Fixed next build by setting JS-target to "es2015" since private fields are used in src/services/openapi
  3. Added a middleware to proxy the API calls to the backend (so you don't have to open two ports)

@GerardSmit GerardSmit requested a review from DevYukine January 25, 2024 22:01
Copy link

codacy-production bot commented Jan 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+44.96% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1bcd6fc) 607 37 6.10%
Head commit (5409d5d) 1569 (+962) 801 (+764) 51.05% (+44.96%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@DevYukine DevYukine merged commit aad319f into main Jan 26, 2024
6 checks passed
@DevYukine DevYukine deleted the docker branch January 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants