Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DownloadService): use Path.Combine for combining paths #9

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

GerardSmit
Copy link
Contributor

@GerardSmit GerardSmit commented Feb 17, 2024

Before:

Created temporary directory C:\Users\x\AppData\Local\Temp\/MangaMagnet-a34bc563-9467-4944-969b-0e9b2f4f2e7a

After:

Deleted temporary directory C:\Users\x\AppData\Local\Temp\MangaMagnet-2eabd02e-93b6-4bb9-87d8-aeba77ac1c7f

Copy link

codacy-production bot commented Feb 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+31.52% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e5b719) 1268 50 3.94%
Head commit (5ec0c30) 2600 (+1332) 922 (+872) 35.46% (+31.52%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#9) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@DevYukine DevYukine merged commit 27eadd4 into develop Feb 17, 2024
5 checks passed
@DevYukine DevYukine deleted the fix/path-combine branch February 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants