Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete onNixOS attribute #209

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haruki7049
Copy link

onNixOS dusturbs creating flake.nix, because pkgs.callPackage ./. { }; is almost used in flake.nix, as:

{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable";
    flake-parts.url = "github:hercules-ci/flake-parts";
  };

  outputs =
    inputs:
    inputs.flake-parts.lib.mkFlake { inherit inputs; } {
      systems = [
        "x86_64-linux"
        "aarch64-linux"
      ];

      perSystem = { pkgs, ... }:
        let
          simila = pkgs.callPackage ./. { };
        in
        {
          packages = {
            inherit simula;
          };

          checks = {
            inherit simula;
          };
        };
    };
}

I think that Simula must run on the machine installed Nix with same code, so onNixOS must be deleted. Also, I think devBuild must be deleted by this reasons.

@haruki7049
Copy link
Author

I don't know why did SimulaVR team create this attribute, so please tell me the reasons if you know that.

@haruki7049
Copy link
Author

This definition is using onNixOS value

vulkan-loader-custom = if onNixOS then vulkan-loader else (callPackage ./nix/vulkan-loader.nix { });

@georgewsinger
Copy link
Collaborator

non-NixOS machines require Simula to run with nixGLIntel or nixGLNvidia.

@haruki7049
Copy link
Author

Was there any solution other than nixGL?

@georgewsinger
Copy link
Collaborator

None that we could find. Possible that things have changed since then.

@haruki7049
Copy link
Author

I checked that pkgs.godot_4 is unable to run on Ubuntu-24.04.1. At that time, it said an error about OpenGL.

Nix files and log: https://gist.github.com/haruki7049/82d150c45e064ec490eec84a91bf2508

However, I think that nixGL should be used by client side only, because in nixpkgs repo, pkgs.godot_4 uses pkgs.libGL but nixGL is not used.

@haruki7049
Copy link
Author

Then I think that nixGL should be deleted in SimulaVR/Simula repo, such as /utils/GetNixGL.sh. Because nixGL installation should do by user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants