Don't classload FluidRenderHandler on dedicated server #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silences some warnings in dedicated server logs
|
Can we move the reference to the fluid render handler registry to |
Su5eD
approved these changes
Nov 12, 2024
|
Seems to work as expected. Thanks for the quality PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The
FluidRenderHandlerclass is classloaded during mod init (specificallyFluidHandlerCompat#initFabricFluidTypes) on dedicated servers, causing a crash due to the classloading of the client-only classTextureAtlasSprite.The Proposal
The access to
FluidRenderHandlerRegistryhas been moved fromFluidHandlerCompat#initFabricFluidTypestoFluidHandlerCompatClient#onRegisterClientExtensions.Possible Side Effects
None that I can think of.
Alternatives
It's possible an
@OnlyIn(Dist.CLIENT)marker somewhere might also work?Additional Notes
See #1501 for a more complete description of the issue.
Additionally, the mixins that should only be loaded on the client have been marked as such in the
.mixins.json, silencing a few warnings in the logs on dedicated servers.