Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIE-2957 add flake8 checking #16

Merged
merged 2 commits into from
Apr 11, 2024
Merged

AIE-2957 add flake8 checking #16

merged 2 commits into from
Apr 11, 2024

Conversation

jclerman
Copy link
Collaborator

@jclerman jclerman commented Mar 29, 2024 •
edited
Loading

Summary

  • Adding flake8 to the pre-commit configuration, with a hopefully-reasonable initial configuration.
    • NOTE: For now, ignoring checks for missing docstrings, since there are so many. Those should be added and the checks enabled.
  • Also added end-of-file fixer pre-commit hook. It removed extra blank lines from the ends of many files but none of those seem like they were needed in the first place.

@jclerman
Add flake8 and fix issues raised by it.
b415da9 
NOTE: For now, ignoring checks for missing docstrings, since there are so many.
      Those should be added and the checks enabled.
@jclerman jclerman self-assigned this Mar 29, 2024
quirky-username
quirky-username approved these changes Apr 3, 2024
View reviewed changes
Copy link

@quirky-username quirky-username left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint prs are fun

@jclerman jclerman merged commit 0af1913 into master Apr 11, 2024
3 checks passed
@jclerman jclerman deleted the AIE-2957-add-flake8 branch April 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quirky-username quirky-username quirky-username approved these changes

@msoedov msoedov msoedov approved these changes

@skucherlapati skucherlapati Awaiting requested review from skucherlapati

Assignees

@jclerman jclerman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jclerman @msoedov @quirky-username