Fix #111

Skouat · Feb 22, 2025 · 39fc1a8 · 39fc1a8
1 parent f10cd44
commit 39fc1a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 27 deletions.
diff --git a/controller/admin/overview_controller.php b/controller/admin/overview_controller.php
@@ -19,7 +19,7 @@
 use phpbb\user;
 use skouat\ppde\actions\core;
 use skouat\ppde\actions\locale_icu;
-use skouat\ppde\controller\extension_manager;
+use skouat\ppde\controller\ext_manager;
 use skouat\ppde\controller\esi_controller;
 use skouat\ppde\controller\main_controller;
 
@@ -60,16 +60,14 @@ class overview_controller extends admin_main
 	 * @param locale_icu              $ppde_actions_locale          PPDE Locale actions object
 	 * @param main_controller         $ppde_controller_main         Main controller object
 	 * @param transactions_controller $ppde_controller_transactions Admin transactions controller object
-	 * @param extension_manager       $ppde_ext_manager             Extension manager object
+	 * @param ext_manager             $ppde_ext_manager             Extension manager object
 	 * @param esi_controller          $esi_controller              IPN PayPal object
 	 * @param request                 $request                      Request object
 	 * @param template                $template                     Template object
 	 * @param user                    $user                         User object
 	 * @param string                  $adm_relative_path            phpBB admin relative path
 	 * @param string                  $phpbb_root_path              phpBB root path
 	 * @param string                  $php_ext                      phpEx
-	 *
-	 * @access public
 	 */
 	public function __construct(
 		auth $auth,
@@ -80,7 +78,7 @@ public function __construct(
 		locale_icu $ppde_actions_locale,
 		main_controller $ppde_controller_main,
 		transactions_controller $ppde_controller_transactions,
-		extension_manager $ppde_ext_manager,
+		ext_manager $ppde_ext_manager,
 		esi_controller $esi_controller,
 		request $request,
 		template $template,
@@ -114,9 +112,7 @@ public function __construct(
 	 *
 	 * @param string $action Action name
 	 *
-	 * @return void
 	 * @throws \ReflectionException
-	 * @access public
 	 */
 	public function display_overview(string $action): void
 	{
@@ -143,9 +139,7 @@ public function display_overview(string $action): void
 	 *
 	 * @param string $action The action to be executed.
 	 *
-	 * @return void
 	 * @throws \ReflectionException
-	 * @access private
 	 */
 	private function do_action(string $action): void
 	{
@@ -167,9 +161,6 @@ private function do_action(string $action): void
 	 * Display confirm box
 	 *
 	 * @param string $action Requested action
-	 *
-	 * @return void
-	 * @access private
 	 */
 	private function display_confirm(string $action): void
 	{
@@ -197,9 +188,7 @@ private function display_confirm(string $action): void
 	/**
 	 * @param string $action Requested action
 	 *
-	 * @return void
 	 * @throws \ReflectionException
-	 * @access private
 	 */
 	private function exec_action(string $action): void
 	{
@@ -256,7 +245,6 @@ private function prepare_template_vars($ext_meta): array
 	 * @param string $config_name
 	 *
 	 * @return string
-	 * @access private
 	 */
 	private function per_day_stats(string $config_name): string
 	{
@@ -267,7 +255,6 @@ private function per_day_stats(string $config_name): string
 	 * Returns the number of days from the date of installation of the extension.
 	 *
 	 * @return float
-	 * @access private
 	 */
 	private function get_install_days(): float
 	{
@@ -295,8 +282,6 @@ private function prepare_sandbox_template_vars(): array
 	/**
 	 * Handles the 'date' action.
 	 * Resets the installation date to yesterday and logs the action.
-	 *
-	 * @return void
 	 */
 	private function handle_date_action(): void
 	{
@@ -307,8 +292,7 @@ private function handle_date_action(): void
 	/**
 	 * Handles the 'esi' (Extension System Information) action.
 	 * Triggers a retest of the extension's system information and logs the action.
-	 *
-	 * @return void
+	 * @throws \ReflectionException
 	 */
 	private function handle_esi_action(): void
 	{
@@ -320,8 +304,6 @@ private function handle_esi_action(): void
 	/**
 	 * Handles the 'sandbox' action.
 	 * Updates the overview statistics for the sandbox environment and logs the action.
-	 *
-	 * @return void
 	 */
 	private function handle_sandbox_action(): void
 	{
@@ -333,8 +315,6 @@ private function handle_sandbox_action(): void
 	/**
 	 * Handles the 'stats' action.
 	 * Updates the overview statistics for the live environment and logs the action.
-	 *
-	 * @return void
 	 */
 	private function handle_stats_action(): void
 	{

diff --git a/controller/esi_controller.php b/controller/esi_controller.php
@@ -23,11 +23,11 @@ class esi_controller
 	 * Constructor.
 	 *
 	 * @param config            $config           Configuration object
-	 * @param extension_manager $ppde_ext_manager Extension manager object
+	 * @param ext_manager $ppde_ext_manager Extension manager object
 	 */
 	public function __construct(
 		config $config,
-		extension_manager $ppde_ext_manager
+		ext_manager $ppde_ext_manager
 	)
 	{
 		$this->config = $config;

diff --git a/controller/extension_manager.php → controller/ext_manager.php b/controller/extension_manager.php → controller/ext_manager.php
@@ -10,7 +10,7 @@
 
 namespace skouat\ppde\controller;
 
-class extension_manager extends \phpbb\extension\manager
+class ext_manager extends \phpbb\extension\manager
 {
 	/** Extension name  */
 	protected const EXT_NAME = 'skouat/ppde';