Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration API Compatibility #130

Merged
merged 46 commits into from
Jan 18, 2025
Merged

Conversation

Pikachu920
Copy link
Member

No description provided.

@Pikachu920 Pikachu920 force-pushed the feature/registration-api-compat branch from b65abe0 to 0eea331 Compare December 31, 2024 19:04
@Pikachu920 Pikachu920 force-pushed the feature/registration-api-compat branch from c2d9a2b to e16944a Compare January 14, 2025 07:28
@Pikachu920 Pikachu920 marked this pull request as ready for review January 14, 2025 19:52
@Pikachu920
Copy link
Member Author

tumblr_o69ni4H9Xc1terwlso1_500-459348924

@@ -15,7 +15,7 @@
public class ExprRawExpression extends SimpleExpression<Expression> {
static {
Skript.registerExpression(ExprRawExpression.class, Expression.class, ExpressionType.COMBINED,
"[the] raw %objects%");
"[the] raw [expression] %objects%");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provides a means to workaround conflict with skript's raw expr

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (even the parts I did of course!)

@APickledWalrus APickledWalrus merged commit bcf6a4d into 2.x Jan 18, 2025
2 checks passed
@APickledWalrus APickledWalrus deleted the feature/registration-api-compat branch January 18, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants