Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl 1.1 #79

Closed
wants to merge 2 commits into from
Closed

Openssl 1.1 #79

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2018

This change set contains two parts:

  1. update vendor/resty/hmac.lua to version 0.02
  2. Ensure the appropriate OpenSSL API is used. Similar to jkeys089/lua-resty-hmac@b53f5ed

@cdbattags
Copy link

cdbattags commented May 23, 2018

Any news on when this is expected? I'm trying to use this with https://github.com/zmartzone/lua-resty-openidc/blob/master/lib/resty/openidc.lua and I'd rather not use an old version of openssl when I could just help y'all here!

Looks like https://travis-ci.org/SkyLothar/lua-resty-jwt/builds/380204655 is failing on Socket.pm tests at response_body - response is expected .

Looks like it's just a cert problem? Cert used to sign the JWT isn't trusted: certificate has expired

Thoughts, @cybrq-as?

Edit:

Haha all the tests are failing due to these expired certs... Lemme see what I can do.

@fermaem, I believe you were last to update these? Anything specific to know? Just go gen some new ones and we good? Last updated in April 2016.

@ghost
Copy link
Author

ghost commented May 23, 2018

Hello @cdbattags. I believe the certificate issues are fixed with #74.

After having contacted @SkyLothar by email and not getting a reply I am wondering whether this repository is still maintained. May be someone is on vacation already... But then again, there are pull-requests from end of last year still open.

@cdbattags
Copy link

cdbattags commented May 23, 2018 via email

@ghost
Copy link
Author

ghost commented May 23, 2018

Go for it. I am happy to contribute the fixes wherever they are needed. Let me know.

@miconx
Copy link

miconx commented May 29, 2018

does anyone have a solution for this problem (updated package maybe?)
ich have the problem that my keycloak installation is not working anymore because of this :-(

@fheyer
Copy link

fheyer commented May 29, 2018

I'm also interested in this patch. Support for OpenSSL 1.1 would be a win. I tested this patch and it works.

@cdbattags
Copy link

Hiya folks, so I've been away on vacation for Memorial Day here in the states and back tomorrow to push on this. Plan for me is to fork this repo, new name and package publish for Luarocks and then PR/notify all packages I can find that depend on this. Thoughts?

I don't have too much experience with Lua/OpenResty but I'd love to step up to the plate on this since I'll be using it across my current project on all "API gateways".

@ghost
Copy link
Author

ghost commented May 29, 2018

@cdbattags Sounds like a good plan. Let me know where I have to commit the patches to.

@cdbattags
Copy link

cdbattags commented May 30, 2018

I had hella troubles getting the expired cert updated but since that's decently minor I went ahead and forked.

Should be getting word back on luarocks/luarocks-site#133 any minute for my module to be added to the root manifest.

See https://github.com/cdbattags/lua-resty-jwt for latest changes. I included these specific commits (from this PR) on v0.1.12 and skipped other current PRs until we can get the certs updated in my fork and Travis tests passing.

@ghost
Copy link
Author

ghost commented May 30, 2018

Perfect! Closing this pull-request.

@ghost ghost closed this May 30, 2018
@ChristianCiach
Copy link

Could you please publish to OPM? This just broke our system, because zmartzone/lua-resty-openidc depends on this package.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants