Toggle component #4249
Merged
Toggle component #4249
+61
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoutMH
suggested changes
Feb 6, 2025
...ashboards_and_Low_Code_Apps/Visualizations/Available_visualizations/Basic_controls/Toggle.md
Outdated
Show resolved
Hide resolved
…lizations/Available_visualizations/Basic_controls/Toggle.md
@WoutMH, if you have no further comments, the pull request will get a final review by @MariekeGO and it will probably be published tomorrow. |
|
@WoutMH, I almost forgot to mention this, but I also noticed that there are currently two categories called "General" in the Layout pane of the toggle component. This feels a bit strange, but is of course no big issue. |
|
No further comments on this PR. The 2 'general' sections are indeed a bit weird, we never notices this was the case (also in the other input components). I'll create a task to update this |
MariekeGO
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WoutMH, could you please review this pull request to confirm the accurate inclusion of release notes 41845, 41903, 41859, and 41911 in the user guide? Thanks in advance!