Add page assignment before return from get_or_create_page

[satansdeer]

Add page assignment before returning page

---

Important

Assigns page before returning in get_or_create_page() in browser_factory.py to ensure initialization.

• Behavior:
  • Assigns page variable before returning in get_or_create_page() in browser_factory.py to ensure it is initialized.
• Functions:
  • Modifies get_or_create_page() to include page = await self.get_working_page() before returning.

^{This description was created by for 5a1c7e3. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 5a1c7e3 in 1 minute and 35 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyvern/webeye/browser_factory.py:549

• Draft comment:
  Consider capturing the return value of __assert_page() (which already guarantees a valid page) instead of calling get_working_page() again. This reduces duplicate async calls and potential state inconsistencies.
• Reason this comment was not posted:
  Marked as duplicate.

2. skyvern/webeye/browser_factory.py:493

• Draft comment:
  Typo detected: 'target_lenght' should be renamed to 'target_length' for clarity and correctness.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. skyvern/webeye/browser_factory.py:602

• Draft comment:
  Typo detected: 'excuted' should be corrected to 'executed' to properly describe that the browser cleanup has been completed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. skyvern/webeye/browser_factory.py:618

• Draft comment:
  Typo detected: 'broswer' should be corrected to 'browser' in the log message to avoid confusion.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_ft2wXvzc6XbQI0A8

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider capturing the return of __assert_page() directly (since it returns a Page) instead of calling get_working_page() again. This ensures consistency and avoids duplicate calls.

Suggested change

	page = await self.get_working_page()
	page = await self.__assert_page()