Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined hoe fixes #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Sefiraat
Copy link
Member

@Sefiraat Sefiraat commented Jul 5, 2021

Description

Combined hoes have not been working as intended. Couldn't till grass. Seeds added aren't saved and broken plants wouldn't trigger the 3x3 area.

Changes

Added EquimentSlot field for updateHeldItemStack.
Added updateHeldItemStack to GuiClose and PlantSeeds saving the seed type and amount correctly.
Changed material check to GRASS_BLOCK.
Set seed bag to Right click air only, otherwise it opens when planting seed and is generally more convenient to separate the actions, updated lore to suit.
Protection check was incorrectly inverted and would only break protected blocks. Reversed.

Related Issues

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Sefiraat Sefiraat requested a review from a team as a code owner July 5, 2021 22:31
@TheBusyBot TheBusyBot added the Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflicts This Pull Request has merged conflicts which need to be resolved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants