[import] Fix comma in role

SlovakNationalGallery · Dec 13, 2024 · d3615db · d3615db
1 parent dbc18c3
commit d3615db
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/Helpers/general.php b/app/Helpers/general.php
@@ -325,7 +325,7 @@ function convertEmptyStringsToNull($array) {
 }
 
 function formatName($name) {
-    return preg_replace('/^([^,]*),\s*(.*)$/', '$2 $1', $name);
+    return preg_replace('/^([^,–]*),\s*(.*)$/', '$2 $1', $name);
 }
 
 function starts_with_upper($str) {

diff --git a/app/Importers/UpmImporter.php b/app/Importers/UpmImporter.php
@@ -93,7 +93,7 @@ protected function hydrateAuthor(array $record): string
                     return $author;
                 }
 
-                return sprintf('%s (%s)', formatName($matches['name']), $matches['role']);
+                return sprintf('%s – %s', formatName($matches['name']), $matches['role']);
             })
             ->join('; ');
     }

diff --git a/tests/Importers/UpmImporterTest.php b/tests/Importers/UpmImporterTest.php
@@ -42,7 +42,7 @@ public function testImport()
         $item = Item::find('CZE:UPM.GK_11090');
 
         $this->assertEquals('GK 11090/E', $item->identifier);
-        $this->assertEquals('Luboš Kopáč (návrh vazby)', $item->author);
+        $this->assertEquals('Jiří Rathouský – grafická úprava, design vazby a přebalu', $item->author);
         $this->assertEquals(1928, $item->date_earliest);
         $this->assertEquals(1928, $item->date_latest);
         $this->assertEquals('1986', $item->acquisition_date);
@@ -89,7 +89,7 @@ private function fakeData(array $overrides = []): array
             "ID" => "GK_11090",
             "Název" => "Vazba knihy",
             "Název EN" => "Binding design",
-            "Autor" => "Kopáč, Luboš – návrh vazby",
+            "Autor" => "Rathouský, Jiří – grafická úprava, design vazby a přebalu",
             "Vznik" => "Praha;VŠUP atelier V.H.Brunnera (vazba)",
             "Datace" => "1928",
             "Od" => "1928",