You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration Consistency: Ensure that the templating and variable substitutions in the Kubernetes manifests are correctly implemented and consistent across different environments.
Resource Limits: Review the specified resource limits and requests in the HelmRelease for the Dagger Engine to ensure they are appropriate for the expected workload.
Dependency Management: Verify that the dependencies, such as the HelmRepository and Kustomization resources, are correctly configured and that the versions specified are compatible with each other.
Add additional dependencies to the kubectl_manifest resource to ensure all necessary resources are ready before application
Consider adding a depends_on attribute for the kubectl_manifest "karpenter" to ensure that the resources it depends on are created or updated before this manifest is applied. This can help avoid potential race conditions where the manifest is applied before the necessary resources are ready.
Why: The suggestion correctly identifies a potential race condition and provides a solution by adding dependencies to ensure the necessary resources are ready before applying the manifest. This is a best practice for improving the reliability of the deployment process.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Configuration changes, Documentation
Description
Changes walkthrough 📝
17 files
data.tf
Add data sources for Kubernetes manifests in EKS module
terraform/eks/data.tf
karpenter.tf
Refactor Karpenter manifests to use template files
terraform/eks/karpenter.tf
kubectl_manifest
resource to use template files.variables.tf
Add variable for Karpenter node pool limits
terraform/eks/variables.tf
karpenter_limits
for defining limits per node pool.default-ec2nc.yaml
Add EC2NodeClass manifest for default node pool
terraform/eks/kubernetes-manifests/karpenter/default-ec2nc.yaml
default-nodepool.yaml
Add NodePool manifest for default node pool
terraform/eks/kubernetes-manifests/karpenter/default-nodepool.yaml
io-ec2nc.yaml
Add EC2NodeClass manifest for IO node pool
terraform/eks/kubernetes-manifests/karpenter/io-ec2nc.yaml
io-nodepool.yaml
Add NodePool manifest for IO node pool
terraform/eks/kubernetes-manifests/karpenter/io-nodepool.yaml
configmap.yaml
Add ConfigMap for Dagger engine configuration
tooling/base/dagger-engine/configmap.yaml
deployment.yaml
Add Deployment for Dagger engine
tooling/base/dagger-engine/deployment.yaml
kustomization.yaml
Add kustomization file for Dagger engine
tooling/base/dagger-engine/kustomization.yaml
network-policy.yaml
Add NetworkPolicy for Dagger engine
tooling/base/dagger-engine/network-policy.yaml
pdb.yaml
Add PodDisruptionBudget for Dagger engine
tooling/base/dagger-engine/pdb.yaml
service.yaml
Add Service for Dagger engine
tooling/base/dagger-engine/service.yaml
controller-helmrelease.yaml
Add HelmRelease for GHA runner scale set controller
tooling/base/gha-runners/controller-helmrelease.yaml
dagger-scale-set-helmrelease.yaml
Add HelmRelease for Dagger GHA runner scale set
tooling/base/gha-runners/dagger-scale-set-helmrelease.yaml
kustomization.yaml
Add Dagger scale set HelmRelease to kustomization
tooling/base/gha-runners/kustomization.yaml
kustomization.yaml
Add Dagger engine and GHA runners to kustomization
tooling/mycluster-0/kustomization.yaml
4 files
bug_report.md
Update issue template title format
.github/ISSUE_TEMPLATE/bug_report.md
enhancement.md
Update enhancement template title format and structure
.github/ISSUE_TEMPLATE/enhancement.md
README.md
Update CI documentation and add Dagger example
README.md
README.md
Add example configuration for Karpenter limits
terraform/eks/README.md
karpenter_limits
.8 files
ci.yaml
Use Dagger module for Terraform/Opentofu validation in CI
.github/workflows/ci.yaml
validation.
observability.yaml
Comment out Loki and Vector-Agent in observability stack
clusters/mycluster-0/observability.yaml
kustomization.yaml
Comment out Loki and Vector-Agent in observability kustomization
observability/mycluster-0/kustomization.yaml
vault-clusterissuer.yaml
Update roleId for Vault AppRole in cert-manager
security/base/cert-manager/vault-clusterissuer.yaml
default-scale-set-helmrelease.yaml
Update HelmRelease for default GHA runner scale set
tooling/base/gha-runners/default-scale-set-helmrelease.yaml
externalsecret.yaml
Update ExternalSecret for GHA runner scale set
tooling/base/gha-runners/externalsecret.yaml
network-policy.yaml
Update NetworkPolicy for Dagger GHA runner scale set
tooling/base/gha-runners/network-policy.yaml
source.yaml
Update HelmRepository for GHA runner scale set
tooling/base/gha-runners/source.yaml