Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cilium): upgrade v1.16.5 #630

Merged
merged 1 commit into from
Dec 21, 2024
Merged

chore(cilium): upgrade v1.16.5 #630

merged 1 commit into from
Dec 21, 2024

Conversation

Smana
Copy link
Owner

@Smana Smana commented Dec 21, 2024

PR Type

Enhancement, Documentation


Description

  • Updated the default Cilium version in variables.tf to 1.16.5.
  • Improved documentation in README.md for Flux dependencies and OpenBao cluster setup.
  • Updated Go module dependencies in go.mod and corresponding checksums in go.sum.
  • Added a kubelet configuration with a maxPods value of 100 in the Karpenter manifest.

Changes walkthrough 📝

Relevant files
Enhancement
variables.tf
Update default Cilium version to 1.16.5                                   

opentofu/eks/variables.tf

  • Updated the default value of the cilium_version variable from 1.16.4
    to 1.16.5.
  • +1/-1     
    default-ec2nc.yaml
    Add kubelet configuration to Karpenter manifest                   

    opentofu/eks/kubernetes-manifests/karpenter/default-ec2nc.yaml

    • Added a kubelet configuration with a maxPods value of 100.
    +2/-0     
    Documentation
    README.md
    Improve documentation for Flux and OpenBao setup                 

    README.md

  • Enhanced the description of Flux dependencies with a link to the Flux
    website.
  • Improved wording for the OpenBao cluster setup section.
  • +3/-2     
    Dependencies
    go.mod
    Update Go module dependencies to latest versions                 

    dagger/go.mod

  • Updated multiple dependencies to newer versions, including gqlgen,
    grpc-gateway, and google.golang.org/grpc.
  • +8/-8     
    go.sum
    Update dependency checksums in go.sum                                       

    dagger/go.sum

    • Updated checksums for the updated dependencies in go.mod.
    +16/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Addition

    The addition of the kubelet configuration with maxPods: 100 should be reviewed to ensure it aligns with the intended cluster scaling and pod density requirements.

      kubelet:
        maxPods: 100
    Dependency Updates

    The updates to dependencies, such as grpc-gateway and gqlgen, should be validated to ensure compatibility and no breaking changes in the application.

    	github.com/99designs/gqlgen v0.17.61
    	github.com/Khan/genqlient v0.7.0
    	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
    	github.com/go-logr/logr v1.4.2 // indirect
    	github.com/go-logr/stdr v1.2.2 // indirect
    	github.com/google/uuid v1.6.0 // indirect
    	github.com/grpc-ecosystem/grpc-gateway/v2 v2.25.1 // indirect
    	github.com/jmespath/go-jmespath v0.4.0 // indirect
    	github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
    	github.com/sosodev/duration v1.3.1 // indirect
    	github.com/vektah/gqlparser/v2 v2.5.20
    	go.opentelemetry.io/otel v1.33.0
    	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.9.0
    	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.9.0
    	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.33.0
    	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.33.0
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.33.0 // indirect
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.33.0
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.33.0
    	go.opentelemetry.io/otel/log v0.9.0
    	go.opentelemetry.io/otel/metric v1.33.0
    	go.opentelemetry.io/otel/sdk v1.33.0
    	go.opentelemetry.io/otel/sdk/log v0.9.0
    	go.opentelemetry.io/otel/sdk/metric v1.33.0
    	go.opentelemetry.io/otel/trace v1.33.0
    	go.opentelemetry.io/proto/otlp v1.4.0
    	golang.org/x/exp v0.0.0-20241217172543-b2144cdd0a67
    	golang.org/x/net v0.33.0 // indirect
    	golang.org/x/sync v0.10.0
    	golang.org/x/sys v0.28.0 // indirect
    	golang.org/x/text v0.21.0 // indirect
    	google.golang.org/genproto/googleapis/api v0.0.0-20241219192143-6b3ec007d9bb // indirect
    	google.golang.org/genproto/googleapis/rpc v0.0.0-20241219192143-6b3ec007d9bb // indirect
    	google.golang.org/grpc v1.69.2
    	google.golang.org/protobuf v1.36.0 // indirect
    )

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Validate the maxPods configuration to avoid resource contention or scheduling issues

    Ensure that the maxPods value of 100 is appropriate for the cluster's workload and
    does not exceed the node's capacity or Kubernetes' default limits, as this could
    lead to resource contention or scheduling issues.

    opentofu/eks/kubernetes-manifests/karpenter/default-ec2nc.yaml [9-10]

     kubelet:
    -  maxPods: 100
    +  maxPods: 100 # Ensure this value aligns with node capacity and workload requirements
    Suggestion importance[1-10]: 7

    Why: The suggestion is valid and highlights a critical configuration parameter (maxPods) that could impact the cluster's performance and stability. While it does not propose a specific change, it encourages validation of the value, which is important for ensuring optimal resource utilization and avoiding potential issues.

    7

    @Smana Smana force-pushed the chore_upgrade_cilium_v1.16.5 branch from 889fe12 to d4aea4b Compare December 21, 2024 09:07
    @Smana Smana merged commit 56e9ee8 into main Dec 21, 2024
    3 checks passed
    @Smana Smana deleted the chore_upgrade_cilium_v1.16.5 branch December 21, 2024 09:09
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants