Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various versions upgrade eks, flux-operator, harbor, headlamp #676

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

Smana
Copy link
Owner

@Smana Smana commented Jan 24, 2025

PR Type

Enhancement, Dependencies


Description

  • Upgraded multiple versions for EKS, Flux Operator, Harbor, and Headlamp.

  • Updated dependencies in go.mod and go.sum for compatibility.

  • Adjusted Helm chart versions for Harbor and Headlamp.

  • Updated documentation to reflect version changes.


Changes walkthrough 📝

Relevant files
Enhancement
4 files
variables.tf
Updated default versions for EKS-related variables             
+5/-5     
variables.tf
Updated OpenBao version to 2.1.1                                                 
+1/-1     
helmrelease-harbor.yaml
Upgraded Harbor Helm chart version to 1.16.2                         
+1/-1     
helmrelease.yaml
Upgraded Headlamp Helm chart version and plugin image       
+2/-2     
Dependencies
3 files
dagger.json
Updated Dagger engine version                                                       
+1/-1     
go.mod
Updated dependencies for AWS SDK and OpenTelemetry             
+20/-20 
go.sum
Synced dependency checksums with updated `go.mod`               
+32/-32 
Documentation
2 files
README.md
Updated documentation for EKS variable default versions   
+5/-5     
README.md
Updated OpenBao version in documentation                                 
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @Smana Smana force-pushed the chore_various_upgrades_feb_2025 branch from 024abda to d667e94 Compare January 24, 2025 20:06
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility

    The default Kubernetes cluster version has been updated to 1.32, and other related versions (e.g., Cilium, EBS CSI Driver) have been incremented. Ensure these versions are compatible with the existing infrastructure and configurations.

      default     = "1.32"
      type        = string
    }
    
    variable "enable_ssm" {
      description = "If true, allow to connect to the instances using AWS Systems Manager"
      type        = bool
      default     = false
    }
    
    variable "iam_role_additional_policies" {
      description = "Additional policies to be added to the IAM role"
      type        = map(string)
      default     = {}
    }
    
    variable "cluster_identity_providers" {
      description = "Map of cluster identity provider configurations to enable for the cluster."
      type        = any
      default     = {}
    }
    
    variable "cilium_version" {
      description = "Cilium cluster version"
      default     = "1.16.6"
      type        = string
    }
    
    variable "karpenter_version" {
      description = "Karpenter version"
      default     = "1.1.1"
      type        = string
    }
    
    variable "karpenter_limits" {
      description = "Define limits for Karpenter per node pool."
      type = map(object(
        {
          cpu    = optional(number, 50),
          memory = optional(string, "50Gi")
        }
        )
      )
    }
    
    variable "ebs_csi_driver_chart_version" {
      description = "EBS CSI Driver Helm chart version"
      default     = "2.39.0"
      type        = string
    }
    
    variable "gateway_api_version" {
      description = "Gateway API CRDs version"
      default     = "v1.2.1"
      type        = string
    Plugin Image Update

    The headlamp-plugins init container image has been updated to ghcr.io/headlamp-k8s/headlamp-plugin-flux:latest. Verify that this new image is functional and does not introduce regressions.

    image: ghcr.io/headlamp-k8s/headlamp-plugin-flux:latest
    imagePullPolicy: Always
    name: headlamp-plugins
    volumeMounts:
      - mountPath: /build/plugins
    Dependency Updates

    Multiple dependencies have been updated, including go.opentelemetry.io/otel and google.golang.org/grpc. Validate that these updates do not introduce breaking changes or compatibility issues.

    require github.com/aws/aws-sdk-go v1.55.6
    
    require go.opentelemetry.io/auto/sdk v1.1.0 // indirect
    
    require (
    	github.com/99designs/gqlgen v0.17.63
    	github.com/Khan/genqlient v0.7.0
    	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
    	github.com/go-logr/logr v1.4.2 // indirect
    	github.com/go-logr/stdr v1.2.2 // indirect
    	github.com/google/uuid v1.6.0 // indirect
    	github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.0 // indirect
    	github.com/jmespath/go-jmespath v0.4.0 // indirect
    	github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
    	github.com/sosodev/duration v1.3.1 // indirect
    	github.com/vektah/gqlparser/v2 v2.5.21
    	go.opentelemetry.io/otel v1.34.0
    	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.10.0
    	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.10.0
    	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.34.0
    	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.34.0
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0
    	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.34.0
    	go.opentelemetry.io/otel/log v0.10.0
    	go.opentelemetry.io/otel/metric v1.34.0
    	go.opentelemetry.io/otel/sdk v1.34.0
    	go.opentelemetry.io/otel/sdk/log v0.10.0
    	go.opentelemetry.io/otel/sdk/metric v1.34.0
    	go.opentelemetry.io/otel/trace v1.34.0
    	go.opentelemetry.io/proto/otlp v1.5.0
    	golang.org/x/exp v0.0.0-20250106191152-7588d65b2ba8
    	golang.org/x/net v0.34.0 // indirect
    	golang.org/x/sync v0.10.0
    	golang.org/x/sys v0.29.0 // indirect
    	golang.org/x/text v0.21.0 // indirect
    	google.golang.org/genproto/googleapis/api v0.0.0-20250124145028-65684f501c47 // indirect
    	google.golang.org/genproto/googleapis/rpc v0.0.0-20250124145028-65684f501c47 // indirect
    	google.golang.org/grpc v1.70.0
    	google.golang.org/protobuf v1.36.4 // indirect
    )

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Avoid using the latest tag for images

    Ensure the new image ghcr.io/headlamp-k8s/headlamp-plugin-flux:latest is stable and
    not subject to unexpected changes, as using the latest tag can lead to unpredictable
    behavior if the image is updated without notice.

    tooling/base/headlamp/helmrelease.yaml [31]

    -image: ghcr.io/headlamp-k8s/headlamp-plugin-flux:latest
    +image: ghcr.io/headlamp-k8s/headlamp-plugin-flux:<specific-version>
    Suggestion importance[1-10]: 8

    Why: Using the latest tag for images can lead to unpredictable behavior if the image is updated without notice. Replacing it with a specific version ensures stability and reproducibility, which is critical for production environments.

    8

    @Smana
    Copy link
    Owner Author

    Smana commented Jan 24, 2025

    There's currently an error stating Karpenter is not compatible with Kubernetes version 1.32.
    aws/karpenter-provider-aws#7630

    @Smana Smana force-pushed the chore_various_upgrades_feb_2025 branch 5 times, most recently from 9fa816a to eaff9c8 Compare January 25, 2025 07:00
    @Smana Smana force-pushed the chore_various_upgrades_feb_2025 branch from eaff9c8 to 0a255c3 Compare January 25, 2025 09:10
    @Smana Smana merged commit c709a7f into main Jan 25, 2025
    3 checks passed
    @Smana Smana deleted the chore_various_upgrades_feb_2025 branch January 25, 2025 09:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants