Matter Switch: use parent-child for multi-switch devices #1011
Conversation
ctowns
force-pushed
the
CHAD-11858-matter-switch-parent-child
branch
from
0667ba4 to
b0b3d30
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b0b3d30 |
|
Channel deleted. |
Test Results 52 files ±0 345 suites +1 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit b0b3d30. ± Comparison against base commit 38c1a61. ♻️ This comment has been updated with latest results. |
| { | ||
| type = "EDGE_CHILD", | ||
| label = name, | ||
| profile = "switch-binary", |
There was a problem hiding this comment.
Is it possible to refer to this string by leveraging the fingerprint::deviceProfileName?
There was a problem hiding this comment.
not available in the driver afaik
| label = name, | ||
| profile = "switch-binary", | ||
| parent_device_id = device.id, | ||
| parent_assigned_child_key = string.format("%02X", ep), |
There was a problem hiding this comment.
Is there a utility function available that, provided an ep, returns its formatted value, as It is being used throughout?
|
Running into some issues with testing and need to do some more clean up, but the plan is now to not get this in for the beta deploy today and instead target end of the week. |
| initialize_switch(device) | ||
| if device.network_type == device_lib.NETWORK_TYPE_MATTER then | ||
| device:set_component_to_endpoint_fn(component_to_endpoint) | ||
| device:set_endpoint_to_component_fn(endpoint_to_component) |
There was a problem hiding this comment.
i don't see endpoint_to_component's new definition anywhere
| clusters.OnOff.attributes.OnOff:build_test_report_data(mock_device, 3, true) | ||
| } | ||
| }, | ||
| { |
|
What is the status of this PR is it still needed? |
|
This was merged here: #1094 |
https://smartthings.atlassian.net/browse/CHAD-11858