Matter Thermostat: Fix thermostatMode capability #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matter-thermostat driver is using the "fanOnly" value of the thermostatMode capability. But since this capability requires using the "fanonly" value, events using the "fanOnly" value are ignored. This change renames "fanOnly" to "fanonly". https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#thermostatMode Signed-off-by: Youngho Yoon <[email protected]>
|
|
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9758c0f |
greens
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
based on https://github.ecodesamsung.com/iot/SmartThingsCapabilities/blob/main/datatypes/ThermostatMode.yml
this capitalization is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matter-thermostat driver is using the "fanOnly" value of the thermostatMode capability. But since this capability requires using the "fanonly" value, events using the "fanOnly" value are ignored. This change renames "fanOnly" to "fanonly".
https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#thermostatMode
MTR-439