WWSTCERT-987 Fingerprint Add

[lelandblue]

Fingerprint add for the Door Sensor from Heiman through the Edge Builder Tool.

[github-actions]

Test Results

   55 files    351 suites   0s ⏱️
1 640 tests 1 640 ✅ 0 💤 0 ❌
2 872 runs  2 872 ✅ 0 💤 0 ❌

Results for commit b9f5b1d.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	94%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua	94%	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b9f5b1d

[github-actions]

Channel deleted.

[z-michel]

Seems like this device already covered in: #1026?

[Leo2442926161]

Seems like this device already covered in: #1026?

Yes, we have two sensors are covered in that PR.

[lelandblue]

I'd recommend that we edit that PR to remove the duplicate device and have one device per PR. Each device will be tested individually and could be published on different schedules.

[Leo2442926161]

I'd recommend that we edit that PR to remove the duplicate device and have one device per PR. Each device will be tested individually and could be published on different schedules.

Thanks for your quick response, we actually submitted two matter sensors for WWST, would it make sense if the PR contains two sensors?

[lelandblue]

Hey @Leo2442926161

My understanding is that you have recently submitted two requests.

1. Heiman Motion Sensor models M1-M, PR #1026
2. Heiman Door Sensor models D1-M, in this PR 1032.
   If that is incorrect, please let me know.

Assuming that is correct, we will:

1. Remove the Heiman Door and Window D1-M from PR 1026, and it will remain as part of this PR 1032. Each pull request should contain one device per pull request.
2. Question for the D1-M Device in this PR, Do you want the device label to be "Heiman Door and Window D1-M" OR "Door sensor". The device label is the default name given to a device when it joins our platform. Users will see the device in their home named what is defined in the deviceLabel:. There were differences in how this was submitted so I just want to confirm with you what your preference is. Users can change this after the device joins the platform.

Thank you.

[Leo2442926161]

Hi @lelandblue Thank you very much for your clarifying.
Yes, that is correct.

Q:Remove the Heiman Door and Window D1-M from PR 1026, and it will remain as part of this PR 1032. Each pull request should contain one device per pull request.
A: Do I need to remove the Door sensor and resubmit it in PR1026?

Question for the D1-M Device in this PR, Do you want the device label to be "Heiman Door and Window D1-M" OR "Door sensor". The device label is the default name given to a device when it joins our platform. Users will see the device in their home named what is defined in the deviceLabel:. There were differences in how this was submitted so I just want to confirm with you what your preference is. Users can change this after the device joins the platform.
A: we would like the deviceLabel to be "Heiman Door and Window D1-M", how to change it in this PR?

Thanks again for your help.

[lelandblue]

Hello @Leo2442926161

I want to help make this easy for you. I have edited this PR, to fix the join name to "Heiman Door and Window D1-M". If you are ok with how this PR is and do not need any more changes, please let me know.

I think we can proceed with this PR, and there is no further action needed from you regarding Pull Requests.

Please confirm.

[Leo2442926161]

Hello @Leo2442926161

I want to help make this easy for you. I have edited this PR, to fix the join name to "Heiman Door and Window D1-M". If you are ok with how this PR is and do not need any more changes, please let me know.

I think we can proceed with this PR, and there is no further action needed from you regarding Pull Requests.

Please confirm.

Hi @lelandblue,
That would be great, we confirm that join name is okay for us, thank you very much.