Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: finish restoring popp_danfoss -> danfoss #1043

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: finish restoring popp_danfoss -> danfoss #1043

merged 1 commit into from
Oct 31, 2023

Conversation

dljsjr
Copy link
Contributor

@dljsjr dljsjr commented Oct 31, 2023 •
edited
Loading

Some changes in another PR modified an existing profile in an breaking
way, and we asked for those changes to be reverted in the PR. Some stuff
got missed, though. This addresses the stragglers.

@dljsjr dljsjr requested review from greens and lelandblue October 31, 2023 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Test Results

     54 files     346 suites   0s ⏱️
1 618 tests 1 618 ✔️ 0 💤 0 ❌
2 844 runs  2 844 ✔️ 0 💤 0 ❌

Results for commit 6059f62.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

File Coverage
All files 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 74% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 94% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 6059f62

@dljsjr dljsjr mentioned this pull request Oct 31, 2023
Merged
@dljsjr
Copy link
Contributor Author

dljsjr commented Oct 31, 2023

Failing tests are repro'd locally as well.

@dljsjr
fix: finish restoring popp_danfoss -> danfoss
6059f62 
Some changes in another PR modified an existing profile in an breaking
way, and we asked for those changes to be reverted in the PR. Some stuff
got missed, though. This addresses the stragglers.
@dljsjr dljsjr force-pushed the fix/zigbee-thermostat-bad-template branch from 0dfd74e to 6059f62 Compare October 31, 2023 20:30
@dljsjr dljsjr changed the title fix: add missing comma to fix driver table decl fix: finish restoring popp_danfoss -> danfoss Oct 31, 2023
@dljsjr dljsjr merged commit 11ec65e into main Oct 31, 2023
10 checks passed
@dljsjr dljsjr deleted the fix/zigbee-thermostat-bad-template branch October 31, 2023 20:34
@dljsjr dljsjr mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens approved these changes

@lelandblue lelandblue Awaiting requested review from lelandblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dljsjr @greens