Rolling up beta to production #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matter-thermostat driver is using the "fanOnly" value of the thermostatMode capability. But since this capability requires using the "fanonly" value, events using the "fanOnly" value are ignored. This change renames "fanOnly" to "fanonly". https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#thermostatMode Signed-off-by: Youngho Yoon <[email protected]>
Matter Thermostat: Fix thermostatMode capability
Sometimes old devices are failing to successfully use https to download samsung hosted audio notification files, in that case we should re-attempt with http before completely failing.
* adjust zigbee-thermoatat edge driver to work with popp smart thermostat * adding POPP Smart Thermostat (Zigbee) EdgeDriver * remove custom capabilities try to replace custome modes with thermostat modes * new model id added * move preferences to profile * updated popp thermostat * code refactoring * bugfixing and refactoring * refactor spaces and lineendings * battery report adjusted * popp zigbee thermostat final refactoring * finished popp driver test + minor fix in init function * minor adjustment for custom thermostat attribute configuration * fix luacheck warnings * driver reworked to fit with 285#pullrequestreview-1501647628 * luacheck issues fixed * fix year and indentation * revert changes from review https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/285/files/aca52e4fce7ecbffb6493215eef4d15308c707a7 revert changes from review https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/285/files/aca52e4fce7ecbffb6493215eef4d15308c707a7 avoid breaking existing popp/danfoss edge drivers * revert fingerprint changes --------- Co-authored-by: Marcel Kermer <[email protected]> Co-authored-by: lelandblue <[email protected]>
Some changes in another PR modified an existing profile in an breaking way, and we asked for those changes to be reverted in the PR. Some stuff got missed, though. This addresses the stragglers.
…tat-bad-template
Rolling up main to beta
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
|
matter-thermostat_coverage.xml
zigbee-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1947aff |
cjswedes
approved these changes
Nov 7, 2023
ctowns
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.