Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Thermostat: add temp/humidity offset preferences to profiles #1824

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Dec 13, 2024

CHAD-14584
Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adds temperatureOffset and relativeHumidityOffset preferences to profiles that support the temperatureMeasurement and relativeHumidityMeasurement capabilities.

profile change only

Summary of Completed Tests

Onboarded a thermostat device using one of the updated profiles (thermostat-humidity-fan-nostate) without the changes. Preferences were not visible in the "Settings" menu of the device card. Then, the driver was updated to include the new profile with the preferences added from this PR. Upon driver update, confirmed that the preferences are now visible in the "Settings" menu of the device after the driver is updated. No reonboarding is needed. Offsets working as expected and can be updated by the user in the "Settings" menu.

Adds temperatureOffset and relativeHumidityOffset preferences to profiles that
support the temperatureMeasurement and relativeHumidityMeasurement capabilities.
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Dec 13, 2024

Channel deleted.

Copy link

Test Results

   64 files    402 suites   0s ⏱️
2 001 tests 2 001 ✅ 0 💤 0 ❌
3 455 runs  3 455 ✅ 0 💤 0 ❌

Results for commit d5b1387.

Copy link

File Coverage
All files 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 85%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d5b1387

@ctowns ctowns merged commit f6df83a into main Jan 31, 2025
12 checks passed
@ctowns ctowns deleted the CHAD-14584-matter-thermostat branch January 31, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants