Rolling up main to beta #1849
Merged
Rolling up main to beta #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mirek (or mired) to kelvin conversion can suffer from precision mismatches that can lead to computed Kelvin values slightly above the expected maximum in certain situations. The platform convention is to clamp to steps of 100, so we implement that here when converting from the color temp value we get from the Hue API in to the Kelvin value we use on the platform.
This was some of the first code I wrote for the Hue driver, and I had a misunderstanding of the `min_dimming` property returned by the API. The `min_dimming` value in the API is informative, and represents a percent of the total lumens the device is capable of outputting that you will get if you request the lowest possible brightness for the bulb (1%). We were interpreting it as a lower bound on the values to send, which is not correct. This PR removes the lower bound checks, and instead clamps all dimming commands to the range of [1,100] inclusive.
…ps-hue-dimming-range Hue: Remove incorrect dimming lower bound logic.
- Mostly updates type hints/annotations - Fix one place where typechecks caught a missing nil check
Using `ipairs` here instead of `pairs` meant that any devices that ended up in this queue were never actually being refreshed. Fixes #1674
…n-remote-reliability Hue: Fix multi-component device initialization race condition
Signed-off-by: xiaoming-su <[email protected]>
Signed-off-by: zhou chengyu <[email protected]>
Signed-off-by: zhou chengyu <[email protected]> Co-authored-by: Alissa Dornbos <[email protected]>
Signed-off-by: zhou chengyu <[email protected]> Co-authored-by: Alissa Dornbos <[email protected]>
Fix wistar fingerprint location
|
Channel deleted. |
|
matter-thermostat_coverage.xml
matter-window-covering_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7fd2e7b |
hcarter-775
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.