add maileke air quality detector #1850
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 65 files 405 suites 0s ⏱️ Results for commit e93d1dd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e93d1dd |
| id = 0x0000, | ||
| value_type = data_types.Uint16, | ||
| }, | ||
| pm1_0 = { |
There was a problem hiding this comment.
Are you sure that this attribute is pm1.0? The cluster ID is standard and the attributes are usually MeasuredValue, MinMeasuredValue, MaxMeasuredValue and sometimes 0x0003 for Tolerance.
Especially when you already call the cluster pm2.5, the attributes shouldn't be pm1.0 and so on.
drivers/SmartThings/zigbee-air-quality-detector/profiles/air-quality-detector-maileke.yml
Outdated
Show resolved
Hide resolved
| capabilities.veryFineDustHealthConcern, | ||
| capabilities.veryFineDustSensor, | ||
| capabilities.dustHealthConcern, | ||
| capabilities.fineDustSensor, |
| end | ||
| end | ||
|
|
||
| local function pm2_5_attr_handler(cap,Concern,good,bad) |
There was a problem hiding this comment.
This should be split into separate handlers - IF the device even has pm1.0 and pm10 measurement.
| }, | ||
| [custom_clusters.pm2_5.id] = { | ||
| [custom_clusters.pm2_5.attributes.pm2_5.id] = pm2_5_attr_handler(capabilities.fineDustSensor.fineDustLevel,capabilities.fineDustHealthConcern.fineDustHealthConcern,75,115), | ||
| [custom_clusters.pm2_5.attributes.pm1_0.id] = pm2_5_attr_handler(capabilities.veryFineDustSensor.veryFineDustLevel,capabilities.veryFineDustHealthConcern.veryFineDustHealthConcern,100,0), |
There was a problem hiding this comment.
Is the comparative value of the level of quality
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: AirQualityDetector |
There was a problem hiding this comment.
Without a dashboard, the device tile would look like a temperature sensor with an icon of an air quality sensor.
| end | ||
| end | ||
|
|
||
| local maileke_sensor = { |
There was a problem hiding this comment.
With a life cycle handler ( lifecycle_handlers ) for init, added or do_configure, you could actually configure the clusters. Without configuration, the device won't send anything or fire messages at a rate of 1 per second.
There was a problem hiding this comment.
This is not a sleep end device
|
Here's an example of a driver with custom clusters: https://github.com/ldeora/SmartThingsEdgeDrivers/tree/main/IKEA-VINDSTYRKA-TVOC You can see how you can configure them (the laziest way), some naming conventions, how you can change the device tile and much more. This is a very friendly and helpful community where you can discuss these things before you submit a pull request: |
thinkaName
force-pushed
the
air_quality_maleke
branch
from
0800087 to
c11d654
Compare
thinkaName
force-pushed
the
air_quality_maleke
branch
from
c11d654 to
e93d1dd
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests