-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PPB for TVOC measurement units #1852
Conversation
Channel deleted. |
Test Results 64 files 404 suites 0s ⏱️ Results for commit 5911d09. ♻️ This comment has been updated with latest results. |
matter-sensor_coverage.xml
matter-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5911d09 |
c4df2f0
to
361d16c
Compare
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
These changes should be ported to matter-thermostat as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the testing noted here, this looks good to me 👍
Check all that apply
Type of Change
Checklist
Description of Change
CHAD-14452
TVOC measurements are typically under 1 ppm for normal conditions for indoor air quality (see here). Rounding to the nearest 0.5 ppm is therefore not the most accurate representation and ppb should be used instead.
Summary of Completed Tests
See testing info in the ticket as well as new unit test.