Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PPB for TVOC measurement units #1852

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jan 6, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-14452

TVOC measurements are typically under 1 ppm for normal conditions for indoor air quality (see here). Rounding to the nearest 0.5 ppm is therefore not the most accurate representation and ppb should be used instead.

Summary of Completed Tests

See testing info in the ticket as well as new unit test.

Copy link

github-actions bot commented Jan 6, 2025

Channel deleted.

Copy link

github-actions bot commented Jan 6, 2025

Test Results

   64 files    404 suites   0s ⏱️
2 009 tests 2 009 ✅ 0 💤 0 ❌
3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit 5911d09.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 6, 2025

matter-sensor_coverage.xml

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%

matter-thermostat_coverage.xml

File Coverage
All files 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 85%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 5911d09

@nickolas-deboom nickolas-deboom force-pushed the CHAD-14452-change-tvocMeasurement-unit branch from c4df2f0 to 361d16c Compare January 7, 2025 15:58
@hcarter-775
Copy link
Contributor

hcarter-775 commented Jan 7, 2025

These changes should be ported to matter-thermostat as well
Nevermind, I'm blind

Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the testing noted here, this looks good to me 👍

@nickolas-deboom nickolas-deboom merged commit 0a020b4 into main Jan 8, 2025
12 checks passed
@nickolas-deboom nickolas-deboom deleted the CHAD-14452-change-tvocMeasurement-unit branch January 8, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants