Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eufy E30 and E31 to new-matter-lock driver #1854

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Jan 8, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

https://smartthings.atlassian.net/wiki/spaces/DLT/pages/3642239311/eufy+E30+door+lock+testing

Copy link

github-actions bot commented Jan 8, 2025

Channel deleted.

Copy link

github-actions bot commented Jan 8, 2025

Test Results

   64 files    404 suites   0s ⏱️
2 009 tests 2 009 ✅ 0 💤 0 ❌
3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit 6ea9678.

Copy link

github-actions bot commented Jan 8, 2025

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 6ea9678

@HunsupJung HunsupJung merged commit 686bd72 into main Jan 13, 2025
11 checks passed
@HunsupJung HunsupJung deleted the feature/matter-lock-for-eufy-e30-e31 branch January 13, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants