Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Devices (Matter Switch) 2 Aqara 2 AiDot #1855

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

lelandblue
Copy link
Contributor

Type of Change

  • [ X ] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR adds Four new Fingerprints for the following devices:

  1. Aqara LED Bulb T2 CCT, Matter Device Type ID: 10c
  2. Aqara LED Bulb T2 RGB CCT, Matter Device Type ID: 10d
  3. Aidot OREiN Matter Smart Light Bulb BR30 RGBTW 1200lm, Matter Device Type ID: 10d
  4. Aidot Linkind Matter Smart Light Bulb BR30 RGBTW 1200lm, Matter Device Type ID: 10d

Additionally I moved up the "AiDot fingerprints" to be in alphabetical order compared to the other MFG fingerprints and rearranged them to be ordered more by their ProductIDs.

Summary of Completed Tests

No additional testing is planned

This commit is adding 4 new fingerprints, and moving the AiDot fingerprint section to be in alphabetical order.
Copy link

github-actions bot commented Jan 8, 2025

Test Results

   64 files    404 suites   0s ⏱️
2 009 tests 2 009 ✅ 0 💤 0 ❌
3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit fa713e9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 8, 2025

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against fa713e9

@lelandblue lelandblue merged commit 6e4ec75 into main Jan 9, 2025
15 checks passed
@lelandblue lelandblue deleted the multiple-devices-Jan8 branch January 9, 2025 15:55
cjswedes pushed a commit that referenced this pull request Jan 13, 2025
This commit is adding 4 new fingerprints, and moving the AiDot fingerprint section to be in alphabetical order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants