Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Devices (Matter Lock) Nuki #1857

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

lelandblue
Copy link
Contributor

Type of Change

  • [ X ] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

  1. I am adding two new fingerprints for Matter Nuki Locks the devices are
    a. Model Number: 221148, PID: 0x00C1, Matter Device Type ID: (0xa)
    b. Model Number: 221147, PID: 0x00B2, Matter Device Type ID: (0xa)
  • Please note these devices will later re-certify under the new door lock experience
  1. I also re-arranged the fingerprints in the Nuki section of the Matter lock to be organized by product ID

Summary of Completed Tests

Copy link

github-actions bot commented Jan 9, 2025

Channel deleted.

Copy link

github-actions bot commented Jan 9, 2025

Test Results

   64 files    404 suites   0s ⏱️
2 009 tests 2 009 ✅ 0 💤 0 ❌
3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit 15e7ff3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 9, 2025

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 15e7ff3

@lelandblue lelandblue merged commit cddbdae into main Jan 13, 2025
15 checks passed
@lelandblue lelandblue deleted the new-device/Nuki-221147-221148 branch January 13, 2025 14:34
cjswedes pushed a commit that referenced this pull request Jan 13, 2025
* Re-org and also adding two fingerprints

* update all actions/upload-artifacts ocurrances to v4

---------

Co-authored-by: Harrison Carter <[email protected]>
Co-authored-by: Harrison Carter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants