Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batteryLevel to matter window covering #1860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jan 10, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-12161

Matter drivers currently assume that BatPercentRemaining is available if the BAT feature is supported, but this attribute is only optionally required if this feature is present. The changes in this PR improve the profile selection logic in matter-window-covering by reading the AttributeList, checking if BatPercentRemaining or BatChargeLevel is available, and then profiling the device as needed.

Note that these changes were originally in PR 1796 but this PR was split up into 5 separate PRs, one for each affected driver.

Summary of Completed Tests

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

Copy link

github-actions bot commented Jan 10, 2025

Test Results

   64 files    404 suites   0s ⏱️
2 010 tests 2 010 ✅ 0 💤 0 ❌
3 472 runs  3 472 ✅ 0 💤 0 ❌

Results for commit 5a9fa63.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 10, 2025

File Coverage
All files 71%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/matter-window-covering-position-updates-while-moving/init.lua 36%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 5a9fa63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant